fix(OidcProvider): missing removeEventSubscription (#742)

AxaFrance · Mar 31, 2022 · f9b54ef · f9b54ef
1 parent e30289c
commit f9b54ef
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/packages/context/src/App.tsx b/packages/context/src/App.tsx
@@ -15,7 +15,7 @@ function App() {
         <nav className="navbar navbar-expand-lg navbar-dark bg-primary">
           <a className="navbar-brand" href="/">@axa-fr/react-oidc-context</a>
           <button className="navbar-toggler" type="button" onClick={() => setShow(!show)} data-toggle="collapse" data-target="#navbarNav" aria-controls="navbarNav" aria-expanded="false" aria-label="Toggle navigation">
-            <span className="navbar-toggler-icon"></span>
+            <span className="navbar-toggler-icon"/>
           </button>
           <div style={show ? { display: "block" } : { display: 'none' }} className="collapse navbar-collapse" id="navbarNav">
             <ul className="navbar-nav">

diff --git a/packages/context/src/configurations.ts b/packages/context/src/configurations.ts
@@ -1,6 +1,6 @@
 export const configurationIdentityServer = {
-    client_id: 'interactive.public.short', //  interactive.public.short
-    redirect_uri: window.location.origin+'/authentication/callback', // http://localhost:4200/authentication/callback
+    client_id: 'interactive.public.short', 
+    redirect_uri: window.location.origin+'/authentication/callback', 
     silent_redirect_uri: window.location.origin+'/authentication/silent-callback',
     scope: 'openid profile email api offline_access',
     authority: 'https://demo.duendesoftware.com',
@@ -11,7 +11,7 @@ export const configurationIdentityServer = {
 
 export const configurationAuth0 = {
     client_id: 'xGZxEAJhzlkuQUlWl90y1ntIX-0UDWHx',
-    redirect_uri: window.location.origin+'/callback', // http://localhost:4200/callback
+    redirect_uri: window.location.origin+'/callback',
     scope: 'openid profile email api offline_access',
     authority: 'https://kdhttps.auth0.com',
     refresh_time_before_tokens_expiration_in_second: 70,

diff --git a/packages/context/src/oidc/OidcProvider.tsx b/packages/context/src/oidc/OidcProvider.tsx
@@ -106,6 +106,7 @@ sessionLostComponent=SessionLost }) => {
                 setLoading(false);
             }
         return () => {
+            oidc.removeEventSubscription(subscriptionId);
             isMounted = false;
         }
     }, [configuration, configurationName]);