Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#368] AxonSerializer documentation and enforce ReplayToken.context to String #370

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[#368] AxonSerializer documentation and enforce ReplayToken.context to String #370

wants to merge 7 commits into from

Conversation

MateuszNaKodach
Copy link

@MateuszNaKodach MateuszNaKodach commented Jan 20, 2025 •
edited
Loading

closes #368

smcvb and others added 5 commits July 23, 2024 11:24
@smcvb
Add context field for the ReplayTokenSerializer
6916a76 
Add context field for the ReplayTokenSerializer. Sadly, the context
object is of type Any. Hence, we need to find a way to retrieve a
primitive type serializer and potentially configured serializers.

#bug/support-reset-context
@smcvb
Add todos for the pointer where to work on
7fa5fba 
Add todos for the pointer where to work on

#bug/support-reset-context
@MateuszNaKodach
AxonSerializers - add replyTokenContextSerializer for String objects
89f2383
@MateuszNaKodach
add test replay token with complex object as String context
6e47726
@MateuszNaKodach
AxonSerializers - add KDoc
236c7e2
@CLAassistant
Copy link

CLAassistant commented Jan 20, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@MateuszNaKodach MateuszNaKodach changed the title [#368] AxonSerializer documentation and enforce ReplayToken.context to String #368 AxonSerializer documentation and enforce ReplayToken.context to String Jan 20, 2025
@MateuszNaKodach MateuszNaKodach changed the title #368 AxonSerializer documentation and enforce ReplayToken.context to String [#368] AxonSerializer documentation and enforce ReplayToken.context to String Jan 20, 2025
@MateuszNaKodach MateuszNaKodach self-assigned this Jan 20, 2025
@MateuszNaKodach MateuszNaKodach added this to the Release 4.11.0 milestone Jan 20, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abuijze abuijze Awaiting requested review from abuijze

@CodeDrivenMitch CodeDrivenMitch Awaiting requested review from CodeDrivenMitch

@smcvb smcvb Awaiting requested review from smcvb

At least 1 approving review is required to merge this pull request.

Assignees

@MateuszNaKodach MateuszNaKodach

Labels
Priority 1: Must Type: Enhancement
Projects
None yet
Milestone
Release 4.11.0
Development

Successfully merging this pull request may close these issues.

AxonSerializer documentation and enforce ReplayToken#context to String
3 participants
@MateuszNaKodach @CLAassistant @smcvb