Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new functionality to be able to cancel a search and to set a maximum number of subfolders to search in #17

Merged
merged 8 commits into from
Sep 18, 2024
Merged

Added new functionality to be able to cancel a search and to set a maximum number of subfolders to search in #17

merged 8 commits into from
Sep 18, 2024

Conversation

ericf-axosoft
Copy link
Contributor

@ericf-axosoft ericf-axosoft commented Sep 17, 2024 •
edited
Loading

Summary of changes

  • Added maxSubfolderDeep parameter.
  • Modified the callback to be able to return true to cancel the search.
  • Fix compiling node module with spaces in path.
  • Updated readme file.
  • Added new tests.
  • Fixed GitHub action for the tests.

@ericf-axosoft ericf-axosoft force-pushed the GK-6252-add-new-parameters branch 6 times, most recently from 303ef64 to 7fa015d Compare September 17, 2024 11:32
@ericf-axosoft ericf-axosoft force-pushed the GK-6252-add-new-parameters branch from 7fa015d to 6e8b62b Compare September 17, 2024 14:06
@ericf-axosoft
Copy link
Contributor Author

@ianhattendorf could you please take a look at this PR?
I'm not able to add reviewers.

Thanks!

@ericf-axosoft ericf-axosoft force-pushed the GK-6252-add-new-parameters branch from 6e8b62b to c9ebe0b Compare September 17, 2024 14:14
@ianhattendorf ianhattendorf self-requested a review September 17, 2024 15:51
@ericf-axosoft
Copy link
Contributor Author

@ianhattendorf I also don't know why only one of the test nodes has been executed. The others are waiting all the time.

@ericf-axosoft ericf-axosoft force-pushed the GK-6252-add-new-parameters branch from 8113625 to 2298343 Compare September 18, 2024 09:33
@ericf-axosoft ericf-axosoft force-pushed the GK-6252-add-new-parameters branch from 2298343 to 0aa394e Compare September 18, 2024 09:39
@ianhattendorf ianhattendorf merged commit 2030b09 into Axosoft:master Sep 18, 2024
15 checks passed
@ericf-axosoft ericf-axosoft deleted the GK-6252-add-new-parameters branch September 19, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianhattendorf ianhattendorf ianhattendorf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericf-axosoft @ianhattendorf