APIGOV-29633 - updates for application profile provisioning #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jcollins-axway
commented
Feb 10, 2025
jcollins-axway
commented
- Add new builder method for adding enum labels and values
- Update provisioning to map selected label in request to mapped value
- Create mock type for app profile def testing
jcollins-axway
requested review from
dfeldick,
sbolosan,
vivekschauhan,
alrosca and
dgghinea
as code owners
sbolosan
reviewed
Feb 10, 2025
sbolosan
approved these changes
Feb 10, 2025
sbolosan
approved these changes
Feb 10, 2025
vivekschauhan
approved these changes
Feb 11, 2025
vivekschauhan
approved these changes
Feb 11, 2025
jcollins-axway
added a commit
that referenced
this pull request
Feb 25, 2025
* APIGOV-29629 - add create and removal hooks for APDs (#879) * codegen update * resource updates * gen update * create application profile definition builder * updates to code gen * add debug flag to codegen * update test whitespace * add cleanup hook for agent sto use to remove app profiles * fix unit test * APIGOV-29630 - Hooks for managed application provisioning (#881) * codegen update * resource updates * gen update * create application profile definition builder * updates to code gen * add debug flag to codegen * update test whitespace * add cleanup hook for agent sto use to remove app profiles * fix unit test * remove all traces of governance agent type * discovery to subscribe to managed application profile events * remove governance agent * linting fixes * revert change * update provisioner registration process * add application profile provision handling * add unit tests and updates for man app profiles * linter fixes * remove adding finalizer to MAP resource * update to add APD to ARD on registration * subscribe to application profile definitions events and update cache * APIGOV-29632 - fixes found while testing with agent (#886) * update caching for app prof def * fix watch topic * add bool prop builder * update to add application profile name to all access requests * fixes for boolean property * add tests for boolean property builder * APIGOV-29633 - updates for application profile provisioning (#887) * update property builder to allow setting enum map * add func to get mapped enums from schema * update man app prof handling for mapped types * update ar and cred processing for enum mapping * add new mock type for testing * update string builder to only add enum map when present * fix type * handle man app profs with mp resources * update application profile ard referencing * update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.