Skip to content

Commit

Permalink
Fix vet warning in devicemapper.
Browse files Browse the repository at this point in the history
Issue moby#11828

Signed-off-by: Félix Baylac-Jacqué <[email protected]>
  • Loading branch information
picnoir committed Mar 27, 2015
1 parent a196cc9 commit 6b764bb
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
5 changes: 3 additions & 2 deletions pkg/devicemapper/devmapper.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"os"
"runtime"
"syscall"
"unsafe"

log "github.com/Sirupsen/logrus"
)
Expand Down Expand Up @@ -226,7 +227,7 @@ func (t *Task) GetDriverVersion() (string, error) {
return res, nil
}

func (t *Task) GetNextTarget(next uintptr) (nextPtr uintptr, start uint64,
func (t *Task) GetNextTarget(next unsafe.Pointer) (nextPtr unsafe.Pointer, start uint64,
length uint64, targetType string, params string) {

return DmGetNextTarget(t.unmanaged, next, &start, &length,
Expand Down Expand Up @@ -512,7 +513,7 @@ func GetStatus(name string) (uint64, uint64, string, string, error) {
return 0, 0, "", "", fmt.Errorf("Non existing device %s", name)
}

_, start, length, targetType, params := task.GetNextTarget(0)
_, start, length, targetType, params := task.GetNextTarget(unsafe.Pointer(nil))
return start, length, targetType, params, nil
}

Expand Down
6 changes: 3 additions & 3 deletions pkg/devicemapper/devmapper_wrapper.go
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ func dmTaskGetDriverVersionFct(task *CDmTask) string {
return C.GoString((*C.char)(buffer))
}

func dmGetNextTargetFct(task *CDmTask, next uintptr, start, length *uint64, target, params *string) uintptr {
func dmGetNextTargetFct(task *CDmTask, next unsafe.Pointer, start, length *uint64, target, params *string) unsafe.Pointer {
var (
Cstart, Clength C.uint64_t
CtargetType, Cparams *C.char
Expand All @@ -231,8 +231,8 @@ func dmGetNextTargetFct(task *CDmTask, next uintptr, start, length *uint64, targ
*params = C.GoString(Cparams)
}()

nextp := C.dm_get_next_target((*C.struct_dm_task)(task), unsafe.Pointer(next), &Cstart, &Clength, &CtargetType, &Cparams)
return uintptr(nextp)
nextp := C.dm_get_next_target((*C.struct_dm_task)(task), next, &Cstart, &Clength, &CtargetType, &Cparams)
return nextp
}

func dmUdevSetSyncSupportFct(syncWithUdev int) {
Expand Down

0 comments on commit 6b764bb

Please sign in to comment.