[proxy] check rank

AzisabaNetwork · Apr 18, 2022 · 517f1eb · 517f1eb
1 parent 1b5e8fc
commit 517f1eb
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/...ain/java/net/azisaba/azipluginmessaging/api/protocol/handler/ProxyboundSetRankPacket.java b/...ain/java/net/azisaba/azipluginmessaging/api/protocol/handler/ProxyboundSetRankPacket.java
@@ -20,6 +20,7 @@
 import java.io.DataInputStream;
 import java.io.IOException;
 import java.time.Instant;
+import java.util.List;
 import java.util.Objects;
 import java.util.UUID;
 
@@ -45,8 +46,18 @@ public void handle(@NotNull PacketSender sender, @NotNull ProxyboundSetRankMessa
         if (!track.containsGroup(msg.getRank())) {
             throw new IllegalArgumentException("Group is not in a track: " + msg.getRank());
         }
-        boolean modified = false;
         NodeMap nodes = user.getData(DataType.NORMAL);
+        List<String> groups = track.getGroups();
+        int rankIndex = groups.indexOf(msg.getRank());
+        for (String group : groups) {
+            if (LuckPermsUtil.findNode(nodes, group, msg.getServer()) != null) {
+                if (groups.indexOf(group) >= rankIndex) {
+                    throw new IllegalArgumentException(msg.getPlayer().getUsernameOrUniqueId() +
+                            " already inherits the same or higher rank in the track: " + msg.getRank());
+                }
+            }
+        }
+        boolean modified = false;
         for (String group : track.getGroups()) {
             if (msg.getServer().equals(group)) continue;
             Node node = LuckPermsUtil.findNode(nodes, group, msg.getServer());

diff --git a/build.gradle.kts b/build.gradle.kts
@@ -6,7 +6,7 @@ plugins {
 }
 
 group = "net.azisaba.azipluginmessaging"
-version = "2.1.1"
+version = "2.1.2"
 
 repositories {
     mavenCentral()