Make namespace configurable and improve config&logger handling #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to pass the namespace that should be used for discovering servers in. (The default setting of an empty/null namespace should still behave like before and discover in any namespaces)
I also expanded the config handling to allow defining of the options via environment variables as well as loading of the config file from the plugin's DataDirectory directly (this avoids potential issues in environments where
/
is not the path separator or where the DataDirectory is not the default one)Additionally to that I moved the Logger from JUL to the Velocity-devs suggested slf4j one (and directly included stacktraces in the errors). That results in better compatibility with certain environments as the JUL to slf4j translation which Velocity ships as a fallback can break in some cases. (E.g. when running inside containers it can log as
ERROR
instead of at the proper level)