Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

fixed the typo #4

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jayendranarumugam
Copy link

@jayendranarumugam jayendranarumugam commented May 2, 2020

Added ; EOL

Purpose

Fixed the typo by adding EOL

  • ...

Does this introduce a breaking change?

[ ] Yes
[ x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Added ; EOL
updated the tenant id parameter needed for azure app service
@nonik0
Copy link
Contributor

nonik0 commented May 7, 2020

@jayendranarumugam Thanks for correct the typo for the missing semicolon, but the tenant ID parameter should not be required in most scenarios. Can you explain your reasoning here for adding it?

@jayendranarumugam
Copy link
Author

Hi @nonik0 ,
For us without the tenant-id this code was working in our local. However when we pushed into Azure, it's thrown the error like

System.Data.SqlClient.SqlException (0x80131904), NoValidAccessTokenException: No valid access token for use

Even though we have done all the correct pre-req. After this we contact MS Support. As they suggested to put the tenant-id. After that it worked.

So I thought it would be better to include in this doc as well.

P.S: Our web app and sql are in same tenant,

@nonik0
Copy link
Contributor

nonik0 commented May 11, 2020

@jayendranarumugam Thanks for sharing, I still believe you shouldn't need this parameter because you should be getting a token for the same tenant so I'd like to understand your scenario better.

What identity is your application using in Azure? Managed identity, user-assigned managed identity, service principal with secret/cert cred? How is AppAuth configured, using a connection string? Thanks!

@jayendranarumugam
Copy link
Author

@nonik0 we are using Azure Web App. The Web App and the Azure SQL DB are in the same tenant.
We used System Managed Identity from Azure Web App.

Our AppAuth is connecting via the system managed identity and the connection string

To be more specific this is our support ticket which was created support ticket id: 120050623002218

Please let me know if you have more details.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants