Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add chat-history and refactor chat logic to a controller #159

Merged
merged 13 commits into from
Dec 5, 2023

Conversation

shibbas
Copy link
Contributor

@shibbas shibbas commented Dec 4, 2023

Purpose

Feature:

Refactor:

  • Decoupled chat message processing logic from rendering into a separate controller. This allows custom chat component to be created but still keep the parsing and processing by reusing the chat controller.
  • Also fixed the bug where thoughts and data points could not be selected per message
  • Fixed copy to copy the entire text
  • Fixed the bug where the chat thread was not being sent for requests in the context
  • Fixed the bug where '?' was dropped in the follow up question parsing

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code
npm run test:playwright

What to Check

Verify that the following are valid

Verify that the following are valid

Chat history button shows up for chat, but not ask
Chat history is preserved in the localstorage as an example
History is included in the context for the chat.

Other Information

@shibbas shibbas linked an issue Dec 4, 2023 that may be closed by this pull request
@shibbas shibbas merged commit 56b2d62 into main Dec 5, 2023
6 checks passed
@anfibiacreativa anfibiacreativa deleted the chore/chat-controller-refactor-with-chat-history branch January 19, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[frontend] save user chat history
2 participants