Skip to content

Commit

Permalink
chore: remove install-config-file flag from the aro hcp service template
Browse files Browse the repository at this point in the history
The install-config-file is an optional flag that is only used within the Hive provisioner. This is not required
for running CS on ARO HCP mode, therefore we should remove it from the template.

This removes the volume mount path '/configs/service' which only contains this install config yaml file and is not
used by anything else. It can safely be removed.
  • Loading branch information
JameelB committed Oct 22, 2024
1 parent 53b6ade commit 20df625
Showing 1 changed file with 0 additions and 28 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -323,28 +323,6 @@ objects:
jwks.json: ""
acl.yml: ""

- apiVersion: v1
kind: ConfigMap
metadata:
name: clusters-service
labels:
app: clusters-service
namespace: ${NAMESPACE}
data:
# This file contains the default OpenShift installer configuration. It
# will be read when a new cluster is created, and merged with the
# configuration dynamically generated by the service.
install-config.yaml: |
apiVersion: v1
kind: InstallConfig
imageContentSources:
- source: quay.io/openshift-release-dev/ocp-release
mirrors:
- quay.io/openshift-release-dev/ocp-release
- source: quay.io/openshift-release-dev/ocp-v4.0-art-dev
mirrors:
- quay.io/openshift-release-dev/ocp-v4.0-art-dev
- apiVersion: v1
kind: ConfigMap
metadata:
Expand Down Expand Up @@ -443,9 +421,6 @@ objects:
- name: proxy
configMap:
name: cluster-proxy-service-config
- name: config
configMap:
name: clusters-service
- name: azure-runtime-config
configMap:
name: azure-runtime-config
Expand Down Expand Up @@ -500,8 +475,6 @@ objects:
mountPath: /configs/region-constraints
- name: proxy
mountPath: /configs/proxy
- name: config
mountPath: /configs/service
- name: mixin-pull-secret
mountPath: /secrets/mixin-pull-secret
- name: instance-types
Expand Down Expand Up @@ -561,7 +534,6 @@ objects:
- --environment=${ENVIRONMENT}
- --backplane-url=${BACKPLANE_URL}
- --provision-shards-config=/secrets/shards/config
- --install-config-file=/configs/service/install-config.yaml
- --proxy-config-file=/configs/proxy/config.yaml
- --aws-sts-policy-directory=/configs/policies
- --mixin-pull-secret-path=/secrets/mixin-pull-secret
Expand Down

0 comments on commit 20df625

Please sign in to comment.