Skip to content

Commit

Permalink
Review remarks
Browse files Browse the repository at this point in the history
  • Loading branch information
janboll committed Nov 21, 2024
1 parent 64cc4f7 commit 280e476
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
7 changes: 4 additions & 3 deletions config/config.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -226,15 +226,16 @@
"name": {
"type": "string"
},
"minimumTlsVersionAllowed": {
"type": "string"
"minTLSVersion": {
"type": "string",
"enum": ["1.2"]
}
},
"additionalProperties": false,
"required": [
"maxClientSessionsPerAuthName",
"name",
"minimumTlsVersionAllowed"
"minTLSVersion"
]
},
"imageBase": {
Expand Down
2 changes: 1 addition & 1 deletion config/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ defaults:
eventGrid:
name: arohcp-maestro-{{ .ctx.regionShort }}
maxClientSessionsPerAuthName: '4'
minimumTlsVersionAllowed: '1.2'
minTLSVersion: '1.2'
certDomain: 'selfsigned.maestro.keyvault.azure.com'
postgres:
name: arohcp-maestro-{{ .ctx.regionShort }}
Expand Down
2 changes: 1 addition & 1 deletion dev-infrastructure/configurations/region.tmpl.bicepparam
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ param regionalDNSSubdomain = '{{ .regionalDNSSubdomain }}'
param maestroKeyVaultName = '{{ .maestro.keyVaultName }}'
param maestroEventGridNamespacesName = '{{ .maestro.eventGrid.name }}'
param maestroEventGridMaxClientSessionsPerAuthName = {{ .maestro.eventGrid.maxClientSessionsPerAuthName }}
param maestroEventGridMinimumTlsVersionAllowed = '{{ .maestro.eventGrid.minimumTlsVersionAllowed }}'
param maestroEventGridMinimumTlsVersionAllowed = '{{ .maestro.eventGrid.minTLSVersion }}'

0 comments on commit 280e476

Please sign in to comment.