Enable goimports linter

.golangci.yml

@@ -13,9 +13,13 @@ linters:
   disable-all: true
   enable:
     - errcheck
+    - goimports
     - gosimple
     - govet
     - ineffassign
     - staticcheck
     - typecheck
     - unused
+linters-settings:
+  goimports:
+    local-prefixes: github.com/Azure/ARO-HCP

api/redhatopenshift/HcpCluster/hcpCluster-models.tsp

@@ -258,9 +258,6 @@ model PlatformProfile {
   /** The core outgoing configuration */
   outboundType?: OutboundType = OutboundType.loadBalancer;
 
-  /** Specifies whether subnets are pre-attached with an NSG */
-  preconfiguredNsgs: boolean;
-
   /** The id of the disk encryption set to be used for etcd.
    * Configure this when `etcdEncryption` is set to true
    * Is used the https://learn.microsoft.com/en-us/azure/storage/common/customer-managed-keys-overview

frontend/frontend.go

@@ -15,10 +15,11 @@ import (
 	"strings"
 	"sync/atomic"
 
+	"github.com/prometheus/client_golang/prometheus/promhttp"
+
 	"github.com/Azure/ARO-HCP/internal/api"
 	"github.com/Azure/ARO-HCP/internal/api/arm"
 	"github.com/Azure/ARO-HCP/internal/metrics"
-	"github.com/prometheus/client_golang/prometheus/promhttp"
 )
 
 const (

frontend/metrics.go

@@ -8,10 +8,10 @@ import (
 	"strconv"
 	"time"
 
+	"github.com/prometheus/client_golang/prometheus"
 	"golang.org/x/exp/maps"
 
 	"github.com/Azure/ARO-HCP/internal/metrics"
-	"github.com/prometheus/client_golang/prometheus"
 )
 
 type PrometheusEmitter struct {

frontend/middleware_logging_test.go

@@ -9,9 +9,10 @@ import (
 	"testing"
 	"time"
 
+	"github.com/google/uuid"
+
 	"github.com/Azure/ARO-HCP/internal/api"
 	"github.com/Azure/ARO-HCP/internal/api/arm"
-	"github.com/google/uuid"
 )
 
 const (

internal/api/registry.go

@@ -9,8 +9,9 @@ import (
 	"reflect"
 	"strings"
 
-	"github.com/Azure/ARO-HCP/internal/api/arm"
 	validator "github.com/go-playground/validator/v10"
+
+	"github.com/Azure/ARO-HCP/internal/api/arm"
 )
 
 const (