feat: remove explicit properties enabling specific cs provisioner steps

Now the steps are enabled by default, and the properties that
enable/disable some of them have been renamed

dev-infrastructure/docs/development-setup.md

@@ -393,12 +393,6 @@ Then register it with the Maestro Server
         "subnet_resource_id": "$SUBNETRESOURCEID",
         "network_security_group_resource_id":"$NSG"
       },
-      "properties": {
-        "provisioner_hostedcluster_step_enabled": "true",
-        "provisioner_managedcluster_step_enabled": "true",
-        "np_provisioner_provision_enabled": "true",
-        "np_provisioner_deprovision_enabled": "true"
-      },
       "version": {
         "id": "openshift-v4.17.0"
       }

internal/ocm/ocm.go

@@ -28,20 +28,8 @@ type ClusterServiceClientSpec interface {
 func getDefaultAdditionalProperities() map[string]string {
 	// additionalProperties should be empty in production, it is configurable for development to pin to specific
 	// provision shards or instruct CS to skip the full provisioning/deprovisioning flow.
-	additionalProperties := map[string]string{
-		// Enable the ARO HCP provisioner during development. For now, if not set a cluster will not progress past the
-		// installing state in CS.
-		"provisioner_hostedcluster_step_enabled": "true",
-		// Enable the provisioning of ACM's ManagedCluster CR associated to the ARO-HCP
-		// cluster during ARO-HCP Cluster provisioning. For now, if not set a cluster will not progress past the
-		// installing state in CS.
-		"provisioner_managedcluster_step_enabled": "true",
-
-		// Enable the provisioning and deprovisioning of ARO-HCP Node Pools. For now, if not set the provisioning
-		// and deprovisioning of day 2 ARO-HCP Node Pools will not be performed on the Management Cluster.
-		"np_provisioner_provision_enabled":   "true",
-		"np_provisioner_deprovision_enabled": "true",
-	}
+	additionalProperties := map[string]string{}
+
 	return additionalProperties
 }