deploy fixes for CS PR env (#792)

follows up on #762 Signed-off-by: Gerd Oberlechner <[email protected]>
Azure · Nov 1, 2024 · 7142af1 · 7142af1
1 parent 7b0a5c4
commit 7142af1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/.github/workflows/services-cd.yml b/.github/workflows/services-cd.yml
@@ -103,7 +103,7 @@
         - name: 'Deploy CS PR check environment dressup'
           if: inputs.deploy_cs_pr_check_deps
           run: |
-            ./svc-deploy.sh $(DEPLOY_ENV) cluster-service svc deploy-pr-env-deps
+            ./svc-deploy.sh ${DEPLOY_ENV} cluster-service svc deploy-pr-env-deps
 
     deploy_to_management_cluster:
       permissions:

diff --git a/dev-infrastructure/docs/development-setup.md b/dev-infrastructure/docs/development-setup.md
@@ -102,7 +102,7 @@ Every developer creates their own set of service/management clusters, including
 In order to access shared Service Principle credentials you need access to the Key Vault. To grant yourself access, run
 
 ```bash
-az role assignment create --role "Key Vault Secrets User" --assignee $(az ad signed-in-user show --query id -o tsv) --scope $(az keyvault show --name service-kv-aro-hcp-dev --query id -o tsv)
+az role assignment create --role "Key Vault Secrets User" --assignee $(az ad signed-in-user show --query id -o tsv) --scope $(az keyvault show --name aro-hcp-dev-svc-kv --query id -o tsv)
 ```
 
 Note: you only need to run this once. Re-runing it wont hurt, but it will not change anything.
@@ -150,6 +150,14 @@ The base configuration for all Red Hat Azure Subscription based deployments can
 
 The deployment environment used for personal developer infrastructure is found under `.clouds.public.environments.personal-dev`. It inherits from `rh-dev-tmpl` and defines certain overrides.
 
+You can inspect the final results of configuration value overrides by running
+
+  ```bash
+  ./templatize.sh <DEPLOY_ENV> | jq
+  e.g.
+  ./templatize.sh personal-dev | jq
+  ```
+
 ### Access AKS clusters
 
 Running `make infra.all` will provide you with cluster admin on your clusters and kubeconfig files being created under `~/.kube`. The kubeconfigs are named after the resource group name that holds the cluster. The term `svc` and `mgmt` used in these filesnames indicate what cluster they are for.