depends on validation and pipeline fixes

Signed-off-by: Gerd Oberlechner <[email protected]>

dev-infrastructure/region-pipeline.yaml

@@ -2,7 +2,7 @@ serviceGroup: Microsoft.Azure.ARO.Test
 rolloutName: Region Rollout
 resourceGroups:
 - name: {{ .regionRG }}
-  subscription: {{ .serviceClusterSubscription }}
+  subscription: {{ .svc.subscription }}
   steps:
   - name: region
     action: ARM

dev-infrastructure/svc-pipeline.yaml

@@ -1,8 +1,8 @@
 serviceGroup: Microsoft.Azure.ARO.Test
 rolloutName: Service Cluster Rollout
 resourceGroups:
-- name: {{ .serviceClusterRG }}
-  subscription: {{ .serviceClusterSubscription }}
+- name: {{ .svc.rg }}
+  subscription: {{ .svc.subscription }}
   aksCluster: {{ .aksName }}
   steps:
   - name: svc

tooling/templatize/cmd/pipeline/options/options.go

@@ -91,7 +91,7 @@ func (o *ValidatedPipelineOptions) Complete() (*PipelineOptions, error) {
 
 	pipeline, err := pipeline.NewPipelineFromFile(o.PipelineFile, completed.Config)
 	if err != nil {
-		return nil, fmt.Errorf("failed to load pipeline file %s: %w", o.PipelineFile, err)
+		return nil, fmt.Errorf("failed to load pipeline %s: %w", o.PipelineFile, err)
 	}
 
 	return &PipelineOptions{

tooling/templatize/cmd/pipeline/run/options.go

@@ -58,7 +58,7 @@ func (o *RawRunOptions) Validate() (*ValidatedRunOptions, error) {
 	if err != nil {
 		return nil, err
 	}
-	// todo validate
+
 	return &ValidatedRunOptions{
 		validatedRunOptions: &validatedRunOptions{
 			RawRunOptions:            o,

tooling/templatize/pkg/pipeline/run.go

@@ -31,6 +31,10 @@ func NewPipelineFromFile(pipelineFilePath string, vars config.Variables) (*Pipel
 	if err != nil {
 		return nil, err
 	}
+	err = pipeline.Validate()
+	if err != nil {
+		return nil, err
+	}
 	return pipeline, nil
 }
 
@@ -139,3 +143,37 @@ func (s *step) description() string {
 	}
 	return fmt.Sprintf("Step %s\n  Kind: %s\n  %s", s.Name, s.Action, strings.Join(details, "\n  "))
 }
+
+func (p *Pipeline) Validate() error {
+	for _, rg := range p.ResourceGroups {
+		err := rg.Validate()
+		if err != nil {
+			return err
+		}
+	}
+	return nil
+}
+
+func (rg *resourceGroup) Validate() error {
+	if rg.Name == "" {
+		return fmt.Errorf("resource group name is required")
+	}
+	if rg.Subscription == "" {
+		return fmt.Errorf("subscription is required")
+	}
+
+	// validate step dependencies
+	// todo - check for circular dependencies
+	stepMap := make(map[string]bool)
+	for _, step := range rg.Steps {
+		stepMap[step.Name] = true
+	}
+	for _, step := range rg.Steps {
+		for _, dep := range step.DependsOn {
+			if !stepMap[dep] {
+				return fmt.Errorf("invalid dependency from step %s to %s", step.Name, dep)
+			}
+		}
+	}
+	return nil
+}

tooling/templatize/pkg/pipeline/types.go

@@ -21,6 +21,7 @@ type step struct {
 	Env        []EnvVar `yaml:"env"`
 	Template   string   `yaml:"template"`
 	Parameters string   `yaml:"parameters"`
+	DependsOn  []string `yaml:"dependsOn"`
 }
 
 type EnvVar struct {