Review remarks

Azure · Nov 21, 2024 · b44f96e · b44f96e
1 parent 64cc4f7
commit b44f96e
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 8 deletions.
diff --git a/config/config.schema.json b/config/config.schema.json
@@ -226,15 +226,16 @@
               "name": {
                 "type": "string"
               },
-              "minimumTlsVersionAllowed": {
-                "type": "string"
+              "minTLSVersion": {
+                "type": "string",
+                "enum": ["1.2"]
               }
             },
             "additionalProperties": false,
             "required": [
               "maxClientSessionsPerAuthName",
               "name",
-              "minimumTlsVersionAllowed"
+              "minTLSVersion"
             ]
           },
           "imageBase": {

diff --git a/config/config.yaml b/config/config.yaml
@@ -51,7 +51,7 @@ defaults:
     eventGrid:
       name: arohcp-maestro-{{ .ctx.regionShort }}
       maxClientSessionsPerAuthName: '4'
-      minimumTlsVersionAllowed: '1.2'
+      minTLSVersion: '1.2'
     certDomain: 'selfsigned.maestro.keyvault.azure.com'
     postgres:
       name: arohcp-maestro-{{ .ctx.regionShort }}

diff --git a/config/public-cloud-cs-pr.json b/config/public-cloud-cs-pr.json
@@ -57,7 +57,7 @@
     "consumerName": "hcp-underlay-cspr-mgmt-1",
     "eventGrid": {
       "maxClientSessionsPerAuthName": "4",
-      "minimumTlsVersionAllowed": "1.2",
+      "minTLSVersion": "1.2",
       "name": "arohcp-maestro-cspr"
     },
     "imageBase": "quay.io/redhat-user-workloads/maestro-rhtap-tenant/maestro/maestro",

diff --git a/config/public-cloud-dev.json b/config/public-cloud-dev.json
@@ -57,7 +57,7 @@
     "consumerName": "hcp-underlay-dev-mgmt-1",
     "eventGrid": {
       "maxClientSessionsPerAuthName": "4",
-      "minimumTlsVersionAllowed": "1.2",
+      "minTLSVersion": "1.2",
       "name": "arohcp-maestro-dev"
     },
     "imageBase": "quay.io/redhat-user-workloads/maestro-rhtap-tenant/maestro/maestro",

diff --git a/config/public-cloud-personal-dev.json b/config/public-cloud-personal-dev.json
@@ -57,7 +57,7 @@
     "consumerName": "hcp-underlay-usw3tst-mgmt-1",
     "eventGrid": {
       "maxClientSessionsPerAuthName": "4",
-      "minimumTlsVersionAllowed": "1.2",
+      "minTLSVersion": "1.2",
       "name": "arohcp-maestro-usw3tst"
     },
     "imageBase": "quay.io/redhat-user-workloads/maestro-rhtap-tenant/maestro/maestro",

diff --git a/dev-infrastructure/configurations/region.tmpl.bicepparam b/dev-infrastructure/configurations/region.tmpl.bicepparam
@@ -9,4 +9,4 @@ param regionalDNSSubdomain = '{{ .regionalDNSSubdomain }}'
 param maestroKeyVaultName = '{{ .maestro.keyVaultName }}'
 param maestroEventGridNamespacesName = '{{ .maestro.eventGrid.name }}'
 param maestroEventGridMaxClientSessionsPerAuthName = {{ .maestro.eventGrid.maxClientSessionsPerAuthName }}
-param maestroEventGridMinimumTlsVersionAllowed = '{{ .maestro.eventGrid.minimumTlsVersionAllowed }}'
+param maestroEventGridMinimumTlsVersionAllowed = '{{ .maestro.eventGrid.minTLSVersion }}'