prepare RP pipelines for MSFT INT

* add schema options to specify RP image tags * pin RP images for INT Signed-off-by: Gerd Oberlechner <[email protected]>
Azure · Dec 10, 2024 · b8fae65 · b8fae65
1 parent a0f908b
commit b8fae65
Show file tree

Hide file tree

Showing 11 changed files with 56 additions and 6 deletions.
diff --git a/backend/Makefile b/backend/Makefile
@@ -1,6 +1,8 @@
 include ../setup-env.mk
 
-COMMIT ?= $(shell git rev-parse --short=7 HEAD)
+ifndef COMMIT
+COMMIT := $(shell git rev-parse --short=7 HEAD)
+endif
 ARO_HCP_BASE_IMAGE ?= ${ARO_HCP_IMAGE_ACR}.azurecr.io
 ARO_HCP_BACKEND_IMAGE ?= $(ARO_HCP_BASE_IMAGE)/arohcpbackend:$(COMMIT)
 

diff --git a/backend/pipeline.yaml b/backend/pipeline.yaml
@@ -20,3 +20,5 @@ resourceGroups:
       configRef: aksName
     - name: DB_NAME
       configRef: frontend.cosmosDB.name
+    - name: COMMIT
+      configRef: backend.imageTag
diff --git a/config/config.msft.yaml b/config/config.msft.yaml
@@ -141,6 +141,10 @@ clouds:
           imageTag: 0b3c08f
         ocMirror:
           imageTag: 0b3c08f
+      frontend:
+        imageTag: 0b3c08f
+      backend:
+        imageTag: 0b3c08f
 
     environments:
       int:

diff --git a/config/config.schema.json b/config/config.schema.json
@@ -100,9 +100,24 @@
       "armHelperFPAPrincipalId": {
         "type": "string"
       },
+      "backend": {
+        "type": "object",
+        "properties": {
+          "imageTag": {
+            "type": "string"
+          }
+        },
+        "additionalProperties": false,
+        "required": [
+          "imageTag"
+        ]
+      },
       "frontend": {
         "type": "object",
         "properties": {
+          "imageTag": {
+            "type": "string"
+          },
           "cosmosDB": {
             "type": "object",
             "properties": {
@@ -130,6 +145,7 @@
         },
         "additionalProperties": false,
         "required": [
+          "imageTag",
           "cosmosDB"
         ]
       },

diff --git a/config/config.yaml b/config/config.yaml
@@ -143,6 +143,12 @@ clouds:
       # Hypershift Operator
       hypershiftOperator:
         imageTag: 9aca808
+      # Frontend
+      frontend:
+        imageTag: '' # if empty uses commit sha of repo
+      # Backend
+      backend:
+        imageTag: '' # if empty uses commit sha of repo
       # Shared SVC KV
       serviceKeyVault:
         name: 'aro-hcp-dev-svc-kv'

diff --git a/config/public-cloud-cs-pr.json b/config/public-cloud-cs-pr.json
@@ -3,6 +3,9 @@
   "armHelperClientId": "2c6ca254-36bd-43c8-a7a8-fe880bc2c489",
   "armHelperFPAPrincipalId": "bc17c825-6cf8-40d0-8bd6-5536a993115e",
   "aroDevopsMsiId": "/subscriptions/1d3378d3-5a3f-4712-85a1-2485495dfc4b/resourceGroups/global/providers/Microsoft.ManagedIdentity/userAssignedIdentities/aro-hcp-devops",
+  "backend": {
+    "imageTag": ""
+  },
   "baseDnsZoneName": "hcp.osadev.cloud",
   "baseDnsZoneRG": "global",
   "clusterService": {
@@ -29,7 +32,8 @@
       "disableLocalAuth": true,
       "name": "arohcp-rp-cspr",
       "private": false
-    }
+    },
+    "imageTag": ""
   },
   "global": {
     "manageTokenCustomRole": true,

diff --git a/config/public-cloud-dev.json b/config/public-cloud-dev.json
@@ -3,6 +3,9 @@
   "armHelperClientId": "2c6ca254-36bd-43c8-a7a8-fe880bc2c489",
   "armHelperFPAPrincipalId": "bc17c825-6cf8-40d0-8bd6-5536a993115e",
   "aroDevopsMsiId": "/subscriptions/1d3378d3-5a3f-4712-85a1-2485495dfc4b/resourceGroups/global/providers/Microsoft.ManagedIdentity/userAssignedIdentities/aro-hcp-devops",
+  "backend": {
+    "imageTag": ""
+  },
   "baseDnsZoneName": "hcp.osadev.cloud",
   "baseDnsZoneRG": "global",
   "clusterService": {
@@ -29,7 +32,8 @@
       "disableLocalAuth": true,
       "name": "arohcp-rp-dev",
       "private": false
-    }
+    },
+    "imageTag": ""
   },
   "global": {
     "manageTokenCustomRole": true,

diff --git a/config/public-cloud-msft-int.json b/config/public-cloud-msft-int.json
@@ -3,6 +3,9 @@
   "armHelperClientId": "",
   "armHelperFPAPrincipalId": "",
   "aroDevopsMsiId": "/subscriptions/5299e6b7-b23b-46c8-8277-dc1147807117/resourcegroups/global-shared-resources/providers/Microsoft.ManagedIdentity/userAssignedIdentities/aroint-int-public-oidc",
+  "backend": {
+    "imageTag": "0b3c08f"
+  },
   "baseDnsZoneName": "aroapp-hcp.azure-test.net",
   "baseDnsZoneRG": "global-shared-resources",
   "clusterService": {
@@ -29,7 +32,8 @@
       "disableLocalAuth": true,
       "name": "arohcp-rp-int",
       "private": false
-    }
+    },
+    "imageTag": "0b3c08f"
   },
   "global": {
     "manageTokenCustomRole": false,

diff --git a/config/public-cloud-personal-dev.json b/config/public-cloud-personal-dev.json
@@ -3,6 +3,9 @@
   "armHelperClientId": "2c6ca254-36bd-43c8-a7a8-fe880bc2c489",
   "armHelperFPAPrincipalId": "bc17c825-6cf8-40d0-8bd6-5536a993115e",
   "aroDevopsMsiId": "/subscriptions/1d3378d3-5a3f-4712-85a1-2485495dfc4b/resourceGroups/global/providers/Microsoft.ManagedIdentity/userAssignedIdentities/aro-hcp-devops",
+  "backend": {
+    "imageTag": ""
+  },
   "baseDnsZoneName": "hcp.osadev.cloud",
   "baseDnsZoneRG": "global",
   "clusterService": {
@@ -29,7 +32,8 @@
       "disableLocalAuth": true,
       "name": "arohcp-rp-usw3tst",
       "private": false
-    }
+    },
+    "imageTag": ""
   },
   "global": {
     "manageTokenCustomRole": true,

diff --git a/frontend/Makefile b/frontend/Makefile
@@ -1,6 +1,8 @@
 include ../setup-env.mk
 
-COMMIT ?= $(shell git rev-parse --short=7 HEAD)
+ifndef COMMIT
+COMMIT := $(shell git rev-parse --short=7 HEAD)
+endif
 ARO_HCP_BASE_IMAGE ?= ${ARO_HCP_IMAGE_ACR}.azurecr.io
 ARO_HCP_FRONTEND_IMAGE ?= $(ARO_HCP_BASE_IMAGE)/arohcpfrontend:$(COMMIT)
 

diff --git a/frontend/pipeline.yaml b/frontend/pipeline.yaml
@@ -24,3 +24,5 @@ resourceGroups:
       configRef: aksName
     - name: DB_NAME
       configRef: frontend.cosmosDB.name
+    - name: COMMIT
+      configRef: frontend.imageTag