Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra step to check the health of istio version before update #1018

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

jonathan34c
Copy link
Contributor

@jonathan34c jonathan34c commented Dec 20, 2024

edit: dev-infrastructure/scripts/istio.sh to check if the target vers…

Per discuss with AKS team, we need to check if the istio is up running before do the istio upgrade to makesure.

What this PR does

Jira:
Link to demo recording:

Special notes for your reviewer

…ion istio is up and running

Per discuss with AKS team, we need to check if the istio is up running before do the istio upgrade to makesure.
@jonathan34c jonathan34c changed the title edit: dev-infrastructure/scripts/istio.sh to check if the target vers… Add extra step to check the health of istio version before update Dec 20, 2024
@jonathan34c jonathan34c marked this pull request as ready for review December 20, 2024 18:51
Copy link
Contributor

@weinong weinong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weinong weinong merged commit a897e5a into main Dec 23, 2024
6 checks passed
@weinong weinong deleted the jonachang/istiocheck branch December 23, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants