add contributing guide #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrkotas
force-pushed
the
add-contributing
branch
3 times, most recently
from
984cfa7 to
bc0da01
Compare
mjlshen
reviewed
Mar 21, 2024
mjlshen
suggested changes
Mar 21, 2024
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| - [ ] Documentation: Is the documentation updated? Either in the doc located in focus area, in the README or in the code itself. | ||
| - [ ] Customers: Is this change affecting customers? Is the release plan considered? | ||
|
|
||
| ### Release note |
There was a problem hiding this comment.
Do we use this field in a release process?
There was a problem hiding this comment.
Not now, which means it can be added later on.
petrkotas
force-pushed
the
add-contributing
branch
from
bc0da01 to
64e0501
Compare
mjlshen
reviewed
Mar 22, 2024
petrkotas
force-pushed
the
add-contributing
branch
from
64e0501 to
97a76a1
Compare
s-amann
reviewed
Mar 25, 2024
s-amann
reviewed
Mar 26, 2024
petrkotas
force-pushed
the
add-contributing
branch
2 times, most recently
from
ea547f5 to
0056692
Compare
petrkotas
requested review from
UlrichSchlueter,
bennerv and
jharrington22
as code owners
Sets the basic linter and test suite also defines the contributing guide and sets the github pr template
petrkotas
force-pushed
the
add-contributing
branch
from
0056692 to
a8b2d1e
Compare
mjlshen
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the contributing guide I have added the following:
Jira: https://issues.redhat.com/browse/ARO-5975