Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance topic space and permission binding for maestro server. #168

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

morvencao
Copy link
Collaborator

What this PR does

This PR differentiates the topic space for subscribe and publish operations on the Maestro server, ensuring appropriate permissions are bound to each topic space.

Before this PR:

The same topic "source/#" was used by the Maestro server for both subscribing and publishing.

After this PR:

Separate topic spaces are designated for subscribing and publishing, with relevant permissions assigned to each to enhance security and organization.

Jira:
Link to demo recording:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

  • PR: The PR description is expressive enough and will help future contributors
  • Code: Write code that humans can understand and Keep it simple
  • Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
  • Upgrade: Impact of this change on upgrade flows was considered and addressed if required
  • Deployment: The deployment process was considered and addressed if required
  • Testing: New code requires new unit tests.
  • Documentation: Is the documentation updated? Either in the doc located in focus area, in the README or in the code itself.
  • Customers: Is this change affecting customers? Is the release plan considered?

@bennerv bennerv merged commit c7264f3 into main Jun 5, 2024
5 checks passed
@mjlshen mjlshen deleted the br_enhance_maestro_server_topic branch June 5, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants