-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add prom metrics to frontend #54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change requested to eliminate a redundant constant.
3e391a1
to
514f10d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment, otherwise lgtm
413f4b1
to
356e7d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this. 🙂
Just a couple of questions about why not to use the metrics.Emitter interface when possible in the parameters and a question about (*PrometheusEmitter).EmitGauge... syntax.
Thanks!
b2a031d
to
ef7b7bb
Compare
13dffdd
to
2514a4b
Compare
06f76c5
to
34e5125
Compare
It looks like you addressed all of @AldoFusterTurpin's requested changes, so I'm going to dismiss his review in order to unblock this. |
Requested changes have been addressed.
What this PR does
Before this PR:
Frontend has no monitoring
After this PR:
Added prometheus metrics collector and init
Jira: https://issues.redhat.com/browse/ARO-6284
Special notes for your reviewer
curling /metrics shows this:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.