Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metrics interface #55

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

katherinelc321
Copy link
Collaborator

@katherinelc321 katherinelc321 commented Apr 15, 2024

What this PR does

Before this PR:
Frontend has no monitoring
After this PR:
Add metrics interface
Jira: https://issues.redhat.com/browse/ARO-6284
Link to demo recording:

Special notes for your reviewer

Adding metrics package so it can be imported in the next PR

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

  • PR: The PR description is expressive enough and will help future contributors
  • Code: Write code that humans can understand and Keep it simple
  • Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
  • Upgrade: Impact of this change on upgrade flows was considered and addressed if required
  • Deployment: The deployment process was considered and addressed if required
  • Testing: New code requires new unit tests.
  • Documentation: Is the documentation updated? Either in the doc located in focus area, in the README or in the code itself.
  • Customers: Is this change affecting customers? Is the release plan considered?

@katherinelc321 katherinelc321 force-pushed the add-metrics-interface branch from 270e138 to 9e163fc Compare April 15, 2024 17:14
@s-amann s-amann merged commit 3382078 into Azure:main Apr 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants