ARO-10633 | Add ARM Helper Indentity supporting properties #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahitacat
reviewed
Oct 9, 2024
cgiradkar
force-pushed
the
ARO-10633-ARM-Helper-Identity
branch
from
9ae10ca to
8f001cb
Compare
ahitacat
requested changes
Oct 9, 2024
cluster-service/deploy/openshift-templates/arohcp-service-template.yml
Outdated
Show resolved
Hide resolved
cluster-service/deploy/openshift-templates/arohcp-service-template.yml
Outdated
Show resolved
Hide resolved
cluster-service/deploy/openshift-templates/arohcp-service-template.yml
Outdated
Show resolved
Hide resolved
cluster-service/deploy/openshift-templates/arohcp-service-template.yml
Outdated
Show resolved
Hide resolved
cluster-service/deploy/openshift-templates/arohcp-service-template.yml
Outdated
Show resolved
Hide resolved
ahitacat
reviewed
Oct 9, 2024
cgiradkar
force-pushed
the
ARO-10633-ARM-Helper-Identity
branch
2 times, most recently
from
2754c66 to
4b8728b
Compare
ahitacat
requested changes
Oct 10, 2024
cgiradkar
force-pushed
the
ARO-10633-ARM-Helper-Identity
branch
from
4b8728b to
51fe1c8
Compare
cgiradkar
requested review from
bennerv,
jharrington22,
mjlshen,
UlrichSchlueter and
zgalor
as code owners
ahitacat
requested changes
Oct 10, 2024
cluster-service/deploy/openshift-templates/arohcp-service-template.yml
Outdated
Show resolved
Hide resolved
cluster-service/deploy/openshift-templates/arohcp-service-template.yml
Outdated
Show resolved
Hide resolved
cgiradkar
force-pushed
the
ARO-10633-ARM-Helper-Identity
branch
from
51fe1c8 to
c9eacba
Compare
ahitacat
requested changes
Oct 10, 2024
cluster-service/deploy/openshift-templates/arohcp-service-template.yml
Outdated
Show resolved
Hide resolved
cluster-service/deploy/openshift-templates/arohcp-service-template.yml
Outdated
Show resolved
Hide resolved
cgiradkar
force-pushed
the
ARO-10633-ARM-Helper-Identity
branch
from
c9eacba to
d414db5
Compare
ahitacat
requested changes
Oct 11, 2024
There was a problem hiding this comment.
This looks good now 😄
Have you deployed it? It will require the changes in CS https://gitlab.cee.redhat.com/service/uhc-clusters-service/-/merge_requests/8715#c1d3677ee87cc3a195920969d2b562701064aed4
|
Please rebase pull request. |
cgiradkar
force-pushed
the
ARO-10633-ARM-Helper-Identity
branch
from
d414db5 to
3f8669c
Compare
ahitacat
previously approved these changes
Oct 16, 2024
|
After merging the CS MR (910676a), tested again with the latest CS tag and CS could be deployed on svc cluster with pods running as expected. |
cgiradkar
force-pushed
the
ARO-10633-ARM-Helper-Identity
branch
2 times, most recently
from
d14c43f to
e7d370d
Compare
SudoBrendan
requested changes
Oct 23, 2024
There was a problem hiding this comment.
Assuming this relates to https://issues.redhat.com/browse/ARO-10633 ? The work seems good. Can we replace hard-coded CLIENT_ID values with lookups?
Variable lookup support will land soon for ARO HCP infra and service deployments. |
|
Please rebase pull request. |
cgiradkar
force-pushed
the
ARO-10633-ARM-Helper-Identity
branch
from
7c44b88 to
4683e4a
Compare
cgiradkar
changed the title
cgiradkar
force-pushed
the
ARO-10633-ARM-Helper-Identity
branch
from
4683e4a to
5999db5
Compare
cgiradkar
changed the title
cgiradkar
force-pushed
the
ARO-10633-ARM-Helper-Identity
branch
from
5999db5 to
da084e7
Compare
cgiradkar
force-pushed
the
ARO-10633-ARM-Helper-Identity
branch
from
da084e7 to
b7b1bde
Compare
machi1990
reviewed
Nov 27, 2024
cluster-service/deploy/openshift-templates/arohcp-service-template.yml
Outdated
Show resolved
Hide resolved
|
Please rebase pull request. |
cgiradkar
force-pushed
the
ARO-10633-ARM-Helper-Identity
branch
from
b7b1bde to
7173bea
Compare
machi1990
reviewed
Nov 28, 2024
machi1990
reviewed
Nov 28, 2024
cluster-service/deploy/openshift-templates/arohcp-service-template.yml
Outdated
Show resolved
Hide resolved
machi1990
reviewed
Nov 28, 2024
cgiradkar
force-pushed
the
ARO-10633-ARM-Helper-Identity
branch
from
7173bea to
845240a
Compare
cgiradkar
force-pushed
the
ARO-10633-ARM-Helper-Identity
branch
from
845240a to
cbc2b0e
Compare
Signed-off-by: Chetan Giradkar <[email protected]>
cgiradkar
force-pushed
the
ARO-10633-ARM-Helper-Identity
branch
from
cbc2b0e to
e6169d4
Compare
machi1990
approved these changes
Dec 2, 2024
janboll
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Jira: https://issues.redhat.com/browse/ARO-10633, https://issues.redhat.com/browse/ARO-7452
Link to demo recording:
Special notes for your reviewer
Relevant MR in CS: https://gitlab.cee.redhat.com/service/uhc-clusters-service/-/merge_requests/8754