chore: remove install-config-file flag from the aro hcp service template #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The install-config-file is an optional flag that is only used within the Hive provisioner. This is not required for running CS on ARO HCP mode, therefore we should remove it from the template. This removes the volume mount path '/configs/service' which only contains this install config yaml file and is not used by anything else. It can safely be removed.
JameelB
requested review from
bennerv,
jharrington22,
mjlshen,
SudoBrendan,
UlrichSchlueter and
zgalor
as code owners
bennerv
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
The install-config-file is an optional flag that is only used within the Hive provisioner. This is not required for running CS on ARO HCP mode, therefore we should remove it from the template.
This removes the volume mount path '/configs/service' which only contains this install config yaml file and is not used by anything else. It can safely be removed.
Jira: ARO-11242
Link to demo recording: N/A
Special notes for your reviewer
N/A