Add private endpoint for eventgrid #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janboll
force-pushed
the
mqtt-private-endpoint
branch
from
d5e57dd to
759aa05
Compare
janboll
requested review from
bennerv,
geoberle,
jmelis,
jonathan34c,
niontive,
nwnt,
SudoBrendan,
UlrichSchlueter,
weinong and
whober0521
as code owners
geoberle
reviewed
Nov 4, 2024
janboll
changed the title
geoberle
reviewed
Nov 4, 2024
|
Please rebase pull request. |
…e need for copy and paste of DNS Zone names
janboll
force-pushed
the
mqtt-private-endpoint
branch
from
2bd9fbd to
a5dfd29
Compare
janboll
commented
Nov 5, 2024
| param serviceType string | ||
|
|
||
| @description('The group id of the private endpoint service') | ||
| @allowed([ |
There was a problem hiding this comment.
Todo, need to add more types/configuration here for additional private endpoints
geoberle
reviewed
Nov 5, 2024
| @@ -66,5 +66,6 @@ module maestroInfra '../modules/maestro/maestro-infra.bicep' = { | |||
| maxClientSessionsPerAuthName: maestroEventGridMaxClientSessionsPerAuthName | |||
| maestroKeyVaultName: maestroKeyVaultName | |||
| kvCertOfficerManagedIdentityName: maestroKeyVaultCertOfficerMSIName | |||
| publicNetworkAccess: 'Disabled' | |||
There was a problem hiding this comment.
let's keep eventgrid public for now while also using the private endpoint
There was a problem hiding this comment.
Any particular reason?
geoberle
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Jira:
Link to demo recording:
Special notes for your reviewer