Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dedicated endpoint module with standardized one #837

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Replace dedicated endpoint module with standardized one #837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 0 additions & 77 deletions dev-infrastructure/modules/keyvault/keyvault-private-endpoint.bicep
View file
Open in desktop

This file was deleted.

5 changes: 5 additions & 0 deletions dev-infrastructure/modules/private-endpoint.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,14 @@ param location string
@description('The service type the private endpoint is created for')
@allowed([
'eventgrid'
'keyvault'
])
param serviceType string

@description('The group id of the private endpoint service')
@allowed([
'topicspace'
'vault'
])
param groupId string

Expand All @@ -25,6 +27,9 @@ var endpointConfig = {
eventgrid: {
topicspace: 'privatelink.ts.eventgrid.azure.net'
}
keyvault: {
vault: 'privatelink.vaultcore.azure.net'
}
}

resource eventGridPrivateEndpointDnsZone 'Microsoft.Network/privateDnsZones@2020-06-01' = {
Expand Down
9 changes: 5 additions & 4 deletions dev-infrastructure/templates/svc-cluster.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,14 +257,15 @@ module serviceKeyVault '../modules/keyvault/keyvault.bicep' = {

output svcKeyVaultName string = serviceKeyVault.outputs.kvName

module serviceKeyVaultPrivateEndpoint '../modules/keyvault/keyvault-private-endpoint.bicep' = {
module serviceKeyVaultPrivateEndpoint '../modules/private-endpoint.bicep' = {
name: '${deployment().name}-svcs-kv-pe'
params: {
location: location
keyVaultName: serviceKeyVaultName
subnetId: svcCluster.outputs.aksNodeSubnetId
subnetIds: [svcCluster.outputs.aksNodeSubnetId]
vnetId: svcCluster.outputs.aksVnetId
keyVaultId: serviceKeyVault.outputs.kvId
privateLinkServiceId: serviceKeyVault.outputs.kvId
serviceType: 'keyvault'
groupId: 'vault'
}
}

Expand Down
Loading