Receive mock managed identities rp identity in CS #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machi1990
requested review from
bennerv,
geoberle,
janboll,
weinong,
whober0521,
tony-schndr,
jharrington22,
SudoBrendan,
UlrichSchlueter and
zgalor
as code owners
| @@ -272,6 +280,10 @@ objects: | |||
| objectName: ${FPA_CERT_NAME} | |||
| objectType: secret | |||
| objectAlias: firstPartyApplicationCertificateBundle | |||
| - | | |||
There was a problem hiding this comment.
Do we want to approach it having a single SecretProviderClass with N secrets or N SecretProviderClass ? I see different approaches depending on the MR.
|
Having a quick look the approach seems good to me. I'll defer to someone from the lifecycle team to give the ok to the approach as it involves templating and such |
|
lgtm * |
janboll
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Receive mock managed identities rp identity in CS
Jira:
Link to demo recording:
Special notes for your reviewer