Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix command to fit tooling in aro-pipeline #915

Closed
wants to merge 1 commit into from
Closed

Conversation

jonathan34c
Copy link
Contributor

What this PR does

Pair with this PR in msft ADO https://msazure.visualstudio.com/AzureRedHatOpenShift/_git/ARO-Pipelines/pullrequest/11349241?path=/pkg/ev2ra/rolloutparameters.go
to change the command to string instead of array

Jira:
Link to demo recording:

Special notes for your reviewer

Copy link
Collaborator

@mociarain mociarain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but I'm worried about some of the other Shell actions in other parts of the repo?

command: ["make", "deploy"]

How are these affected?

@geoberle
Copy link
Collaborator

geoberle commented Dec 3, 2024

This looks good but I'm worried about some of the other Shell actions in other parts of the repo?

command: ["make", "deploy"]

How are these affected?

the schema for command will change in MSFT tooling from array to string, so all pipeline files need to be adapted and also our tooling needs change. @janboll do you have time to work on this?

@geoberle
Copy link
Collaborator

geoberle commented Dec 4, 2024

complete adaption to string commands can be found here #923

Copy link

github-actions bot commented Dec 4, 2024

Please rebase pull request.

@geoberle geoberle closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants