remove external DNS from MGMT cluster #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoberle
requested review from
bennerv,
janboll,
weinong,
whober0521,
tony-schndr,
jmelis,
jonathan34c,
niontive,
nwnt,
SudoBrendan,
UlrichSchlueter,
jharrington22 and
zgalor
as code owners
mociarain
previously approved these changes
Dec 3, 2024
* remove external DNS managed identity and DNS zone permissions * remove external DNS deployment from MGMT cluster https://issues.redhat.com/browse/ARO-12551 Signed-off-by: Gerd Oberlechner <[email protected]>
Signed-off-by: Gerd Oberlechner <[email protected]>
Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle
force-pushed
the
remove-external-dns
branch
from
b273aa4 to
9dd3806
Compare
|
I left a minor comment to make sure I understand the purpose of a removed parameter. If that removal is correct it lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Jira: https://issues.redhat.com/browse/ARO-12551
Link to demo recording:
Special notes for your reviewer