Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Prefer built-in type "url" over "string" for URL fields #951

Merged
merged 2 commits into from
Dec 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ model ClusterSpec {
* to authenticate against user Azure cloud account
*/
@visibility("read")
issuerUrl: string;
issuerUrl: url;

/** Configuration to override the openshift-oauth-apiserver inside cluster
* This changes user login into the cluster to external provider
Expand Down Expand Up @@ -264,14 +264,14 @@ union NetworkType {
model ConsoleProfile {
/** The cluster web console URL endpoint */
@visibility("read")
url: string;
url: url;
}

/** Information about the API of a cluster. */
model ApiProfile {
/** URL endpoint for the API server */
@visibility("read")
url: string;
url: url;

/** should the API server be accessible from the internet */
@visibility("create", "read")
Expand All @@ -292,10 +292,10 @@ union Visibility {
/** OpenShift cluster proxy configuration */
model ProxyProfile {
/** http proxy config */
httpProxy?: string;
httpProxy?: url;

/** https proxy config */
httpsProxy?: string;
httpsProxy?: url;

/** no proxy config */
noProxy?: string;
Expand Down Expand Up @@ -385,7 +385,7 @@ model ExternalAuthProfile {
/** Token issuer profile */
model TokenIssuerProfile {
/** The URL of the token issuer */
url: string;
url: url;

/** The audience of the token issuer */
audiences: string[];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -927,6 +927,7 @@
"properties": {
"url": {
"type": "string",
"format": "uri",
"description": "URL endpoint for the API server",
"readOnly": true
},
Expand Down Expand Up @@ -1097,6 +1098,7 @@
},
"issuerUrl": {
"type": "string",
"format": "uri",
"description": "URL for the OIDC provider to be used for authentication\nto authenticate against user Azure cloud account",
"readOnly": true
},
Expand All @@ -1122,6 +1124,7 @@
"properties": {
"url": {
"type": "string",
"format": "uri",
"description": "The cluster web console URL endpoint",
"readOnly": true
}
Expand Down Expand Up @@ -2017,10 +2020,12 @@
"properties": {
"httpProxy": {
"type": "string",
"format": "uri",
"description": "http proxy config"
},
"httpsProxy": {
"type": "string",
"format": "uri",
"description": "https proxy config"
},
"noProxy": {
Expand Down Expand Up @@ -2105,6 +2110,7 @@
"properties": {
"url": {
"type": "string",
"format": "uri",
"description": "The URL of the token issuer"
},
"audiences": {
Expand Down
13 changes: 7 additions & 6 deletions internal/api/v20240610preview/generated/client_factory.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

41 changes: 21 additions & 20 deletions internal/api/v20240610preview/generated/constants.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading