-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix config schema for istio and region #958
Conversation
istioctlVersion: "1.23.1" | ||
tag: "prod-stable" | ||
version: "asm-1-22" | ||
newVersion: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick overview of why we need this kind of value would be useful. As I remember it there's some namespace selection going on, but it would be good to confirm.
I don't know how this value gets corrupted when we have concurrent upgrades going on. If we had an upgrade from 1 to 2 running but failed, then we tried to upgrade to 3, we'd need to have config that specified 1->3, since 2->3 wouldn't pick up regions that still were on 1? I don't know if we want that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I don't see the old version used for anything in the script - https://msazure.visualstudio.com/AzureRedHatOpenShift/_git/hcp?path=/ev2/svc/istio/archive/istio.sh&version=GBmain&line=13&lineEnd=14&lineStartColumn=1&lineEndColumn=1&lineStyle=plain&_a=contents
Are we sure we need both parameters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so like i wrote it in the Readme
So basically
- we need to add istio new version and old version in to SVC infra pipeline. and run it( so svc cluster would have both version in the cluster)
- Run the istio pipeline to replace the version.
- Update the svc config to have the new version, and run the svc infra again.
Sorry for the confusion on having the old version in the script. it was a legacy code I forgot to delete from previous version of the shell script. I will delete it.
5ecc2bf
to
f98e224
Compare
What this PR does
Add istio and region schema to the config file.
Pipeline: https://msazure.visualstudio.com/AzureRedHatOpenShift/_build/results?buildId=110131012&view=results
Jira:
Link to demo recording:
Special notes for your reviewer