-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Istio add self signed certs #982
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mociarain
force-pushed
the
istio-add-self-signed-certs
branch
from
December 16, 2024 14:00
d9d18c8
to
ca18f3e
Compare
mociarain
requested review from
bennerv,
mbarnes,
SudoBrendan,
geoberle,
janboll,
jmelis,
jonathan34c,
nwnt,
UlrichSchlueter,
weinong,
whober0521 and
tony-schndr
as code owners
December 16, 2024 14:02
janboll
reviewed
Dec 16, 2024
geoberle
reviewed
Dec 17, 2024
frontend/deploy/helm/frontend/templates/allow-ingress.authorizationpolicy.yaml
Show resolved
Hide resolved
mociarain
force-pushed
the
istio-add-self-signed-certs
branch
from
December 17, 2024 13:15
6d70019
to
db0e0ad
Compare
…nstead of the frontendMI
mociarain
force-pushed
the
istio-add-self-signed-certs
branch
from
December 17, 2024 14:48
db0e0ad
to
1dca4ba
Compare
geoberle
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds the necessary infrastructure and wiring for the frontend to become publicly addressable via Istio using a self-signed certificate.
Special notes for your reviewer
To test just build a svc cluster and deploy/redeploy the
frontend
then run:Tickets: