Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add geo-replications to svc and ocp ACRs #995

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: Add geo-replications to svc and ocp ACRs #995

wants to merge 1 commit into from
+64 −0

Conversation

jfchevrette
Copy link
Collaborator

@jfchevrette jfchevrette commented Dec 17, 2024 •
edited
Loading

What this PR does

  • Add an acr-replication bicep module used to set up a replication
  • Use the acr-replication module in region.bicep to deploy ACR replications for both the svc and ocp ACRs
  • An ACR replication cannot exist in the same region as the parent ACR and the module usage definitions checks for that

Jira: https://issues.redhat.com/browse/ARO-13411
Link to demo recording:

Special notes for your reviewer

@jfchevrette
Copy link
Collaborator Author

@microsoft-github-policy-service agree company="Red Hat"

@jfchevrette jfchevrette force-pushed the acr-replica branch 2 times, most recently from f9ad4d0 to 27b48f4 Compare December 17, 2024 01:17
@jfchevrette jfchevrette changed the title Add ACR replica in global scope WIP: Add ACR replica in global scope Dec 17, 2024
@jfchevrette jfchevrette marked this pull request as draft December 17, 2024 16:46
@jfchevrette jfchevrette changed the title WIP: Add ACR replica in global scope WIP: Add geo-replication to svc and ocp ACRs Dec 18, 2024
@jfchevrette jfchevrette changed the title WIP: Add geo-replication to svc and ocp ACRs WIP: Add geo-replications to svc and ocp ACRs Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennerv bennerv Awaiting requested review from bennerv bennerv is a code owner

@geoberle geoberle Awaiting requested review from geoberle geoberle is a code owner

@janboll janboll Awaiting requested review from janboll janboll is a code owner

@weinong weinong Awaiting requested review from weinong weinong is a code owner

@whober0521 whober0521 Awaiting requested review from whober0521 whober0521 is a code owner

@tony-schndr tony-schndr Awaiting requested review from tony-schndr tony-schndr is a code owner

@jmelis jmelis Awaiting requested review from jmelis jmelis is a code owner

@jonathan34c jonathan34c Awaiting requested review from jonathan34c jonathan34c is a code owner

@nwnt nwnt Awaiting requested review from nwnt

@SudoBrendan SudoBrendan Awaiting requested review from SudoBrendan SudoBrendan is a code owner

@UlrichSchlueter UlrichSchlueter Awaiting requested review from UlrichSchlueter UlrichSchlueter is a code owner

@jharrington22 jharrington22 Awaiting requested review from jharrington22

@zgalor zgalor Awaiting requested review from zgalor

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jfchevrette