Add geo-replications to svc and ocp ACRs #995
Conversation
jfchevrette
requested review from
bennerv,
geoberle,
janboll,
weinong,
whober0521,
tony-schndr,
jmelis,
jonathan34c,
nwnt,
SudoBrendan,
UlrichSchlueter,
jharrington22 and
zgalor
as code owners
|
@microsoft-github-policy-service agree company="Red Hat" |
jfchevrette
force-pushed
the
acr-replica
branch
2 times, most recently
from
f9ad4d0 to
27b48f4
Compare
jfchevrette
changed the title
jfchevrette
force-pushed
the
acr-replica
branch
from
27b48f4 to
1eec2c8
Compare
jfchevrette
changed the title
jfchevrette
changed the title
jfchevrette
changed the title
jfchevrette
force-pushed
the
acr-replica
branch
from
1eec2c8 to
7ece688
Compare
There was a problem hiding this comment.
I think this work is well done, thanks! I don't have questions on the code, only on Acceptance Criteria. The jira is a bit vague so everything here fits well within that, but I imagine we will eventually want replication to every Azure region we support, meaning we'd need an array of locations, which I think would come from our global config file Gerd has stood up, if I'm understanding all of this correctly 😅
At minimum I imagine we'd want that for the OCP ACR so that cluster installs aren't pulling images over an ocean and affecting install/repair times of clusters, right? SVC might be more lenient... but I could also see replication playing a role in our services' resiliency (e.g. we don't want a regional outage in data center A affecting data center B's resiliency - there might actually be MSFT requirements around this (?))
So I guess all that to say - this PR looks great, but what are we trying to build? What do we need to be successful as a service with our replication? Has a DDR been made (do we even need one, or just make that choice here)?
Thanks again for the hard work 👍
|
@SudoBrendan the region template contains the replication resource that references the ACRs (ocp/svc) in the global resource group. Anytime we deploy a region we will get replication without having to maintain a separate list. No reason to maintain a separate list with it implemented this way. There is a DDR btw, SD-DDR-0044, not much is said about global replication besides the ACRs should be replicated in every region the service is provided in. |
|
Thank you both for the reviews! |
|
well done. thank you |
What this PR does
acr-replicationbicep module used to set up a replicationacr-replicationmodule inregion.bicepto deploy ACR replications for both the svc and ocp ACRsJira: https://issues.redhat.com/browse/ARO-13411
Link to demo recording:
Special notes for your reviewer