bump(maestro): bump maestro to 15b3dcff1c9a96a02c516b787e847757dac8c1af #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for entra token refreshing (openshift-online/maestro#231)
machi1990
requested review from
bennerv,
geoberle,
janboll,
weinong,
whober0521,
tony-schndr,
jharrington22,
SudoBrendan,
UlrichSchlueter and
zgalor
as code owners
|
@geoberle can you've a look? |
machi1990
commented
Dec 17, 2024
| @@ -88,7 +89,7 @@ spec: | |||
| - --db-user-file=/secrets/db/db.user | |||
| - --db-password-file=/secrets/db/db.password | |||
| - --db-name-file=/secrets/db/db.name | |||
| - --db-rootcert=/secrets/db/db.ca_cert | |||
There was a problem hiding this comment.
the file /secrets/db/db.ca_cert doesn't exist causing issue when the DB connection string is parsed.
Leaving this to empty will cause the system root cert to be used.
machi1990
commented
Dec 17, 2024
| @@ -54,6 +54,7 @@ spec: | |||
| - --db-user-file=/secrets/db/db.user | |||
| - --db-password-file=/secrets/db/db.password | |||
| - --db-name-file=/secrets/db/db.name | |||
| - --db-rootcert= | |||
There was a problem hiding this comment.
the default value was file that didn't exist.
I am leaving this as empty so that the system root cert will be used.
See https://github.com/Azure/ARO-HCP/pull/998/files#r1888346094
geoberle
approved these changes
Dec 17, 2024
machi1990
added a commit
that referenced
this pull request
Dec 17, 2024
This includes a change that fix a migration issue (openshift-online/maestro#233) observed from the previous bump #998
machi1990
added a commit
that referenced
this pull request
Dec 17, 2024
This includes a change that fix a migration issue (openshift-online/maestro#233) observed from the previous bump #998
geoberle
pushed a commit
that referenced
this pull request
Dec 17, 2024
…57 (#1003) This includes a change that fix a migration issue (openshift-online/maestro#233) observed from the previous bump #998
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
bump(maestro): bump maestro to 15b3dcff1c9a96a02c516b787e847757dac8c1af
This adds support for entra token refreshing (openshift-online/maestro#231)
Jira:
Link to demo recording:
Special notes for your reviewer