Implementation of MISE middleware #4070
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sankur-codes
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
mociarain,
kimorris27,
tsatam,
bitoku and
fahlmant
as code owners
Closed
|
Please rebase pull request. |
sankur-codes
force-pushed
the
sankur-codes/ARO-5946-MISE
branch
from
0321d96 to
b43d743
Compare
sankur-codes
force-pushed
the
sankur-codes/ARO-5946-MISE
branch
5 times, most recently
from
6b53531 to
0a7770e
Compare
sankur-codes
force-pushed
the
sankur-codes/ARO-5946-MISE
branch
2 times, most recently
from
c3d2466 to
183c709
Compare
sankur-codes
force-pushed
the
sankur-codes/ARO-5946-MISE
branch
from
183c709 to
3a0b889
Compare
sankur-codes
force-pushed
the
sankur-codes/ARO-5946-MISE
branch
from
645f5cf to
5f9ebee
Compare
sankur-codes
added
ready-for-review
firefly
github-actions
bot
added
needs-rebase
|
Please rebase pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes ARO-5946. Updated PR for #3555
What this PR does / why we need it:
This PR integrates MISE authentication for our RP to improve security while keeping existing certificate based authentication as a fallback.
Test plan for issue:
Unit tests are included. Testing has been done on dev and proceeding to Canary.
Is there any documentation that needs to be updated for this PR?
No
How do you know this will function as expected in production?
Been tested on INT and in being tested on Canary as well with expected results.