bump golang-ci-lint #4090
Merged
bump golang-ci-lint #4090
+985
−719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevekuznetsov
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
mociarain,
kimorris27,
tsatam,
bitoku,
fahlmant and
sankur-codes
as code owners
stevekuznetsov
commented
Feb 7, 2025
stevekuznetsov
force-pushed
the
skuznets/bump-golang-ci-lint
branch
from
18cf165 to
ed4e5f6
Compare
stevekuznetsov
force-pushed
the
skuznets/bump-golang-ci-lint
branch
from
ed4e5f6 to
728d436
Compare
|
We need to write a Go AST-based refactoring tool to actually change the call-sites for |
Signed-off-by: Steve Kuznetsov <[email protected]>
ginkgo-linter: wrong error assertion. Consider using `Eventually(func(ctx context.Context) error {
return project.VerifyProjectIsReady(ctx)
}).WithContext(ctx).WithTimeout(DefaultEventuallyTimeout).Should(Succeed())` instead (ginkgolinter)
Signed-off-by: Steve Kuznetsov <[email protected]>
S1009: should omit nil check; len() for []string is defined as zero (gosimple) Signed-off-by: Steve Kuznetsov <[email protected]>
SA9009: ineffectual compiler directive due to extraneous space: "// go:generate mockgen -destination=../mocks/$GOPACKAGE/client.go github.com/Azure/msi-dataplane/pkg/dataplane Client" (staticcheck) Signed-off-by: Steve Kuznetsov <[email protected]>
printf: non-constant format string in call to (*github.com/sirupsen/logrus.Entry).Warnf (govet) Signed-off-by: Steve Kuznetsov <[email protected]>
Signed-off-by: Steve Kuznetsov <[email protected]>
Signed-off-by: Steve Kuznetsov <[email protected]>
Signed-off-by: Steve Kuznetsov <[email protected]>
This reverts commit 8aa74d1f5d1f006d840e025bf025ce728cced0c4. Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
force-pushed
the
skuznets/bump-golang-ci-lint
branch
from
728d436 to
933b342
Compare
tsatam
previously approved these changes
Feb 12, 2025
Signed-off-by: Steve Kuznetsov <[email protected]>
tsatam
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile: bump golangci-lint
Signed-off-by: Steve Kuznetsov [email protected]
test/e2e: fixup bad Ginkgo assertions
ginkgo-linter: wrong error assertion. Consider using
Eventually(func(ctx context.Context) error { return project.VerifyProjectIsReady(ctx) }).WithContext(ctx).WithTimeout(DefaultEventuallyTimeout).Should(Succeed())instead (ginkgolinter)Signed-off-by: Steve Kuznetsov [email protected]
pkg/api: remove unnecessary nil checks
S1009: should omit nil check; len() for []string is defined as zero (gosimple)
Signed-off-by: Steve Kuznetsov [email protected]
pkg/util: fix ineffectual compiler directive
SA9009: ineffectual compiler directive due to extraneous space:
"// go:generate mockgen -destination=../mocks/$GOPACKAGE/client.go
github.com/Azure/msi-dataplane/pkg/dataplane Client" (staticcheck)
Signed-off-by: Steve Kuznetsov [email protected]
*: fix non-constant format strings
printf: non-constant format string in call to (*github.com/sirupsen/logrus.Entry).Warnf (govet)
Signed-off-by: Steve Kuznetsov [email protected]
cmd/migrate: add a program to refactor NewCloudError
Signed-off-by: Steve Kuznetsov [email protected]
*: run the program to refactor NewCloudError
Signed-off-by: Steve Kuznetsov [email protected]
pkg/api: refactor NewCloudError to take a static message
Signed-off-by: Steve Kuznetsov [email protected]
Revert "cmd/migrate: add a program to refactor NewCloudError"
This reverts commit 8aa74d1f5d1f006d840e025bf025ce728cced0c4.
Signed-off-by: Steve Kuznetsov [email protected]