-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARO-13921 Add cluster subnets' network security groups to List Cluster Azure Resources output if cluster uses preconfiguredNSG #4099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b751d28
to
6bfd597
Compare
mrWinston
reviewed
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good! I mostly have minor comments regarding style. the only important thing for me would be the nil check for snet.Properties.NetworkSecurityGroup
.
mrWinston
approved these changes
Feb 13, 2025
tsatam
approved these changes
Feb 13, 2025
kimorris27
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes ARO-13921
What this PR does / why we need it:
Currently the List Cluster Azure Resources admin endpoint lists all resources within the managed resource group.
BYO NSGs, that some customers might have configured, belong to different resource groups, and are therefore omitted from this endpoint's output.
This change checks whether a subnet has an NSG that belongs to a different RG, and appends it to the Cluster Resources list.
Test plan for issue:
The test mocks two subnets, one containing a managed NSG, the other containing a BYO NSG, then runs WriteToStream().
That, in turn, calls appendAzureNetworkResources().
The expected result is for both of them to be present in the resulting list.
Is there any documentation that needs to be updated for this PR?
No documentation exists for this functionality.
How do you know this will function as expected in production?
TBD