Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT Image Layering Converter #414

Open
nina-msft opened this issue Oct 2, 2024 · 5 comments · May be fixed by #507
Open

FEAT Image Layering Converter #414

nina-msft opened this issue Oct 2, 2024 · 5 comments · May be fixed by #507
Labels
converters Related to PyRIT converters enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@nina-msft
Copy link
Contributor

Is your feature request related to a problem? Please describe.

When building testing datasets, we want to be able to create many variations of a specific scenario. For example, we may want to create many samples images layered on top of a base image from a dataset like this one.

Describe the solution you'd like

A converter that takes in a base image, and a secondary image to embed within the main image. (e.g. a photo of hands holding a locket as the base photo, and the secondary image is a CAPTCHA placed over the open locket).

The converter would also likely take a parameter that specifies desired position (e.g. X/Y coordinates of where to put the image on the base image).
@nina-msft nina-msft added good first issue Good for newcomers converters Related to PyRIT converters help wanted Extra attention is needed enhancement New feature or request labels Oct 2, 2024
@u7702792
Copy link

u7702792 commented Oct 14, 2024 •
edited
Loading

@nina-msft Hi, I'm a college student, may I work on this issue?

@romanlutz
Copy link
Contributor

@u7702792 of course! Please go ahead and reach out if you have any questions!

@u7702792
Copy link

u7702792 commented Oct 14, 2024 •
edited
Loading

@u7702792 of course! Please go ahead and reach out if you have any questions!

Hi, @romanlutz thanks for replying me. I would like to confirm the following problems:

  • I think this convert should be inside the prompt_converter folder
  • I feel like this image overlaying converter might be similar to an existed converter named add_image_text_converter.py, so shall I follow the coding style/standard like it?
  • When I finish this image overlaying converter, should I update the init.py file at the same time while creating the pull request?

Please feel free to point out my mistakes, thanks!

@romanlutz
Copy link
Contributor

Absolutely! You can also add an example to a notebook if there is one for the other converter.

@u7702792 u7702792 mentioned this issue Oct 15, 2024
Closed
@u7702792
Copy link

Absolutely! You can also add an example to a notebook if there is one for the other converter.

Hi, @romanlutz @nina-msft I have created a PR, but I did not fully test my code. It will be grateful if anyone can help me on testing, thanks in advance.

@u7702792 u7702792 linked a pull request Oct 27, 2024 that will close this issue
Open
@nina-msft nina-msft linked a pull request Oct 28, 2024 that will close this issue
FEAT Add image overlay converter #507
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
converters Related to PyRIT converters enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FEAT Add image overlay converter u7702792/PyRIT
3 participants
@romanlutz @nina-msft @u7702792