-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT Add image layering converter #469
Conversation
@microsoft-github-policy-service agree |
y_pos: Optional[int] = 0, | ||
memory: Optional[MemoryInterface] = None, | ||
): | ||
if not base_image_path: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By making it a required parameter above, you probably do not need this check!
Converter the base image to embed the second image onto it. | ||
|
||
Args: | ||
prompt (str): Not used in this converter but may be required by the interface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep this consistent with the other converters, I would design this as the image file name as the prompt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the advice, I will fix it in the next commit
I will submit a new PR when everything is fixed. |
Description
Tests and Documentation
I have some problems on testing the output by myself. If someone can help me on the test that will be very helpful, sorry for the inconvenient.