Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT Moonshot Attack Module: Insert Punctuation Attack #475

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

FEAT Moonshot Attack Module: Insert Punctuation Attack #475

wants to merge 10 commits into from

Conversation

u7780339
Copy link

Description

@u7780339
Copy link
Author

@microsoft-github-policy-service agree

@u7780339 u7780339 marked this pull request as ready for review October 16, 2024 10:56
@u7780339 u7780339 changed the title add converter and test FEAT Moonshot Attack Module: Insert Punctuation Attack Oct 16, 2024
romanlutz
romanlutz reviewed Oct 17, 2024
View reviewed changes
pyrit/prompt_converter/insert_punctuation_attack_converter.py Outdated Show resolved Hide resolved
pyrit/prompt_converter/insert_punctuation_attack_converter.py Outdated Show resolved Hide resolved
pyrit/prompt_converter/insert_punctuation_attack_converter.py Outdated Show resolved Hide resolved
pyrit/prompt_converter/insert_punctuation_attack_converter.py Outdated Show resolved Hide resolved
pyrit/prompt_converter/insert_punctuation_attack_converter.py Outdated Show resolved Hide resolved
pyrit/prompt_converter/insert_punctuation_attack_converter.py Outdated Show resolved Hide resolved
pyrit/prompt_converter/insert_punctuation_attack_converter.py Outdated Show resolved Hide resolved
pyrit/prompt_converter/insert_punctuation_attack_converter.py Outdated Show resolved Hide resolved
pyrit/prompt_converter/insert_punctuation_attack_converter.py Outdated Show resolved Hide resolved
tests/converter/test_insert_punctuation_converter.py Outdated Show resolved Hide resolved
@romanlutz
Copy link
Contributor

@u7780339 this looks very good! I need to make another pass over the tests, or perhaps one of my teammates can, but other than that this is ready to merge. Well done!

@u7780339 u7780339 marked this pull request as draft October 17, 2024 10:57
@nina-msft nina-msft linked an issue Oct 17, 2024 that may be closed by this pull request
FEAT Moonshot Attack Module: Insert Punctuation Attack #426
Open
@romanlutz
Copy link
Contributor

@u7780339 I just wanted to check in on this. Do you intend to continue or should we consider finishing it up ourselves? No pressure at all, but if we don't hear back in the next week we'll consider it up for grabs.

@romanlutz romanlutz marked this pull request as ready for review November 13, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdheekonda rdheekonda rdheekonda left review comments

@romanlutz romanlutz romanlutz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FEAT Moonshot Attack Module: Insert Punctuation Attack
3 participants
@u7780339 @romanlutz @rdheekonda