-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Global Memory Labels #571
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlundeen2
reviewed
Nov 21, 2024
rlundeen2
reviewed
Nov 21, 2024
rlundeen2
reviewed
Nov 21, 2024
rlundeen2
reviewed
Nov 22, 2024
rlundeen2
approved these changes
Nov 22, 2024
rdheekonda
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
GLOBAL_MEMORY_LABELS
as a.env.local
environment variable that flows through to all prompts sent through an Orchestrator.self._global_memory_labels
is initialized in the constructor of theOrchestrator
base class viadefault_values.get_non_required_value
so that every orchestrator will apply those labels to all prompts saved as memory entries.memory_labels
as a constructor parameter.PromptSendingOrchestrator
'ssend_prompts_async
function andMultiTurnOrchestrator
'sapply_attack_async
. Any labels passed in through these functions take precedence over the global ones in the case of collisions, allowing for users to specify temporary labels for any batch of prompts they send.Testing:
GLOBAL_MEMORY_LABELS
and other relevant tests were updated and re-ran