Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should we default hierarchyClient as false if it's arm and flavor is azure #2999

Closed
qiaozha opened this issue Jan 14, 2025 · 1 comment
Closed

should we default hierarchyClient as false if it's arm and flavor is azure #2999

qiaozha opened this issue Jan 14, 2025 · 1 comment
Assignees
@qiaozha
Labels
HRLC p0 priority 0

Comments

@qiaozha
Copy link
Member

qiaozha commented Jan 14, 2025

currently we have hierarchyClient set as true if it's not specified as false explicitly. but in #2699 we have decided to disable this for mpg. maybe we should change the default value for hierarchyClient if we already know this is for arm and flavor azure.
@qiaozha qiaozha mentioned this issue Jan 14, 2025
Merged
@qiaozha qiaozha added HRLC p0 priority 0 labels Jan 22, 2025
@qiaozha qiaozha self-assigned this Jan 22, 2025
@qiaozha
Copy link
Member Author

qiaozha commented Mar 6, 2025

This is no longer valid #2699 (comment)

@qiaozha qiaozha closed this as completed Mar 6, 2025
@qiaozha qiaozha mentioned this issue Mar 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qiaozha qiaozha

Labels
HRLC p0 priority 0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@qiaozha