Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model namespaces hierarchies #2969

Merged
merged 11 commits into from
Jan 14, 2025
Merged

model namespaces hierarchies #2969

merged 11 commits into from
Jan 14, 2025

Conversation

qiaozha
Copy link
Member

@qiaozha qiaozha commented Dec 30, 2024 •
edited
Loading

fixes #2757

@qiaozha
Copy link
Member Author

qiaozha commented Dec 31, 2024

need to revisit the subpath user experience for ARM, data-plane, non branded.

@qiaozha qiaozha changed the title respect-model-namespaces-as-hierarchies model namespaces hierarchies Jan 2, 2025
@qiaozha
Copy link
Member Author

qiaozha commented Jan 6, 2025

need to revisit the subpath user experience for ARM, data-plane, non branded.

we can provide an option to decide if we want to export multi-level models subpath, for azure scope, it should default to false, for unbranded scope it should default to true.

@qiaozha qiaozha marked this pull request as ready for review January 13, 2025 08:14
MaryGao
MaryGao reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As offline discussed, we could restrict sub-path models to follow the namespace convention then we could have consistant behavior with api layer.

@qiaozha qiaozha mentioned this pull request Jan 14, 2025
Open
@qiaozha qiaozha merged commit 5854c92 into Azure:main Jan 14, 2025
17 checks passed
@qiaozha qiaozha deleted the respect-model-namespaces-as-hierarchies branch January 14, 2025 06:53
@qiaozha qiaozha mentioned this pull request Feb 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaryGao MaryGao MaryGao approved these changes

@sarangan12 sarangan12 Awaiting requested review from sarangan12

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate TypeScript codes with hierarchical folders as namespace
2 participants
@qiaozha @MaryGao