Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable full Ubuntu 22.04 configuration for AMD MI300x #390

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

vanzod
Copy link

@vanzod vanzod commented Jan 9, 2025

This PR introduces the following changes:

  • Enables the use of the AMD flag to configure ROCm drivers and associated installations
  • Automatically downloads and installs amdgpu_install utility
  • Installs Cmake 3.30.5 required by RCCL
  • Fixes the default assignment of user secondary groups video and render

@@ -1,6 +1,18 @@
#!/bin/bash
set -ex

pushd /tmp
wget https://github.com/Kitware/CMake/releases/download/v3.30.5/cmake-3.30.5-linux-x86_64.tar.gz
Copy link

@hpourreza hpourreza Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like v3.30.5 is no longer available. Could you please use https://github.com/Kitware/CMake/releases/download/v3.30.6/cmake-3.30.6-linux-x86_64.tar.gz

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I strongly suggest using the common utility functions to retrieve the version from versions.json, verify your download, and write the component version used to the component_versions.txt so that it's stored in the image for reference.

Most files have examples of doing this, but https://github.com/Azure/azhpc-images/blob/master/common/install_azcopy.sh is fairly simple. This should be done for all components that are being installed.

popd
sudo cp -r share/cmake-3.30 /usr/local/share/
popd
rm -rf cmake-3.30.5-linux-x86_64*

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add hash -r after removing the file to clear the stored path for cmake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants