-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable full Ubuntu 22.04 configuration for AMD MI300x #390
base: master
Are you sure you want to change the base?
Conversation
Skip confirmation prompt
Install newer version of cmake required by MSCCLPP
@@ -1,6 +1,18 @@ | |||
#!/bin/bash | |||
set -ex | |||
|
|||
pushd /tmp | |||
wget https://github.com/Kitware/CMake/releases/download/v3.30.5/cmake-3.30.5-linux-x86_64.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like v3.30.5 is no longer available. Could you please use https://github.com/Kitware/CMake/releases/download/v3.30.6/cmake-3.30.6-linux-x86_64.tar.gz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I strongly suggest using the common utility functions to retrieve the version from versions.json
, verify your download, and write the component version used to the component_versions.txt
so that it's stored in the image for reference.
Most files have examples of doing this, but https://github.com/Azure/azhpc-images/blob/master/common/install_azcopy.sh
is fairly simple. This should be done for all components that are being installed.
popd | ||
sudo cp -r share/cmake-3.30 /usr/local/share/ | ||
popd | ||
rm -rf cmake-3.30.5-linux-x86_64* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add hash -r
after removing the file to clear the stored path for cmake
This PR introduces the following changes:
AMD
flag to configure ROCm drivers and associated installationsamdgpu_install
utilityvideo
andrender