[AppInsights] updating dependency creation #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liliankasem
reviewed
Sep 15, 2022
liliankasem
approved these changes
Sep 15, 2022
kshyju
reviewed
Sep 15, 2022
| </PropertyGroup> | ||
|
|
||
| <Import Project="..\..\build\Common.props" /> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Azure.Functions.Worker.Core" Version="1.7.0-preview1" /> |
There was a problem hiding this comment.
Curious to know why we switched to package reference? Is it to lock this version of AI package to specific version of Worker.Core package?
There was a problem hiding this comment.
Yeah, there's a small tweak in preview1 that we need for this package to work... but there's no need for me to keep revving that one now that I don't need additional changes. It was mostly a local dev improvement to lock this to a published package.
This will eventually go away and back to a proj reference once this is ready for GA.
kshyju
approved these changes
Sep 15, 2022
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
brettsam
force-pushed
the
brettsam/appinsights
branch
from
da56723 to
d79f3b8
Compare
jviau
approved these changes
Sep 19, 2022
|
/check-enforcer evaluate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #998
Using App Insights
StartTelemetryto create dependencies for proper hierarchy. This method does a bunch of work to check Activity trace ids and properly set up the operation and parent ids on telemetry.Original example of an isolated function calling into Table storage:
After this change (note how each entry is a child of the other):
