Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding back crank tool #10717

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

Adding back crank tool #10717

wants to merge 3 commits into from

Conversation

kshyju
Copy link
Member

@kshyju kshyju commented Jan 4, 2025

Adding back crank tool.

This PR consists of two commits. The first commit restores the original changes that were removed in PR #9992. The second commit introduces additional updates made while validating the tool usage flow. So far, validation has been completed for the Windows OS use case. I will address validation for Linux OS (and cleanup after) in a separate PR. A wiki page detailing the usage instructions is currently being drafted in the engineering wiki (WIP) and will be shared with the group later.

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@kshyju kshyju requested a review from a team as a code owner January 4, 2025 00:14
@kshyju kshyju force-pushed the shkr/crankreturns branch from 88cdef7 to 22ceccf Compare January 4, 2025 00:17
@kshyju kshyju requested review from mathewc and AnatoliB January 7, 2025 23:44
@jviau
Copy link
Contributor

jviau commented Jan 8, 2025

Is this the only way to include crank agent? Or can we use https://github.com/dotnet/crank and have a step to install that tool in CI?

@kshyju
Copy link
Member Author

kshyju commented Jan 10, 2025

Is this the only way to include crank agent? Or can we use https://github.com/dotnet/crank and have a step to install that tool in CI?

The change in this PR is to support local developer experience such as creating isolated environment on azure where the benchmarks can be executed (using crank).

@kshyju
Copy link
Member Author

kshyju commented Jan 10, 2025

Is this the only way to include crank agent? Or can we use https://github.com/dotnet/crank and have a step to install that tool in CI?

The change in this PR is to support local developer experience such as creating isolated environment on azure where the benchmarks can be executed (using crank).

Synced with Jacob about this and I am trying this idea on ADO pipeline. Marking this PR as draft for now.

@kshyju kshyju marked this pull request as draft January 10, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants