Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add official build queue-time parameters for test builds #10730

Merged
merged 7 commits into from
Jan 10, 2025
Merged

Conversation

jviau
Copy link
Contributor

@jviau jviau commented Jan 8, 2025

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required -- TODO
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Adds parameters to official-build.yml to streamline testing the build itself. This PR introduces a concept of 'official branches' (dev, in-proc, release/, internal/release/) - these are branches which the rest of the changes in this PR are ignored. For non-official branches, this PR adds the following:

  1. Uses unofficial 1ES templates
  2. Adds queue time param to skip running tests
  3. Adds queue time param to skip signing files

These changes streamline testing CI changes from other branches and avoids resource contention with actual official builds (integration test locks for example)

@jviau jviau added the area: engineering Engineering improvements label Jan 8, 2025
@jviau jviau requested a review from a team as a code owner January 8, 2025 23:36
@jviau jviau merged commit 969f761 into dev Jan 10, 2025
9 checks passed
@jviau jviau deleted the jviau/eng/test-ci branch January 10, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: engineering Engineering improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants