Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added qemu arguments, onboarded rockylinux-9 to local e2e test tool #870

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Added qemu arguments, onboarded rockylinux-9 to local e2e test tool #870

merged 3 commits into from
Feb 13, 2025

Conversation

AhmedBM
Copy link
Contributor

@AhmedBM AhmedBM commented Feb 12, 2025 •
edited
Loading

Description

  • Added support for qemu arguments
  • Removed cpu passthrough (-cpu host) from qemu by default
  • Added rockylinux-9 to local e2e testing tool StartTests.sh and added additional qemu args
  • Fixed remediation flag in e2e tests

Checklist

  • I have read the contribution guidelines.
  • All unit tests are passing.
  • I have merged the latest dev branch prior to this PR submission.
  • I ran pre-commit on my changes prior to this PR submission.
  • I submitted this PR against the dev branch.

@AhmedBM AhmedBM requested a review from a team as a code owner February 12, 2025 22:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2025 •
edited
Loading

Test Results

 40 files  ±0   40 suites  ±0   40m 47s ⏱️ + 6m 12s
  4 tests ±0    4 ✅ ±0   0 💤 ±0  0 ❌ ±0 
160 runs  ±0  140 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 7812980. ± Comparison against base commit 02fd17e.

♻️ This comment has been updated with latest results.

MariusNi
MariusNi approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@MariusNi MariusNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AhmedBM AhmedBM merged commit 81bd796 into dev Feb 13, 2025
94 of 97 checks passed
@AhmedBM AhmedBM deleted the ahbenmes/add_qemu_args branch February 13, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertschaedler3 robertschaedler3 robertschaedler3 approved these changes

@MariusNi MariusNi MariusNi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AhmedBM @robertschaedler3 @MariusNi