Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search tsp #31123

Draft
wants to merge 89 commits into
base: main
Choose a base branch
from
Draft

Search tsp #31123

wants to merge 89 commits into from

Conversation

xiangyan99
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Copy link

openapi-pipeline-app bot commented Oct 21, 2024

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ The required check named Protected Files has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Copy link
Member

@catalinaperalta catalinaperalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got through models-index...will continue again tomorrow

specification/search/Azure.Search/client.tsp Show resolved Hide resolved
specification/search/Azure.Search/main.tsp Outdated Show resolved Hide resolved
specification/search/Azure.Search/main.tsp Outdated Show resolved Hide resolved
specification/search/Azure.Search/main.tsp Outdated Show resolved Hide resolved
specification/search/Azure.Search/main.tsp Show resolved Hide resolved
specification/search/Azure.Search/models-index.tsp Outdated Show resolved Hide resolved
specification/search/Azure.Search/models-index.tsp Outdated Show resolved Hide resolved
@catalinaperalta
Copy link
Member

@xiangyan99 the typespec validation and typespec apiview steps need to be passing as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants